search

mysociety / parlparse

The scraper/parser that produces data for TheyWorkForYou, PublicWhip, etc
Other
61 stars 22 forks source link

Confusing other_names for Barry McElduff #89

Closed tmtmtmtm closed 7 years ago

tmtmtmtm commented 7 years ago

uk.org.publicwhip/person/13825 has two other_names entries, each of which has a different start_date, but neither of which has an end_date. Further, both of them seem to be otherwise identical:

      "other_names": [
        {
          "family_name": "McElduff", 
          "given_name": "Barry", 
          "note": "Main", 
          "start_date": "1998-06-25"
        }, 
        {
          "family_name": "McElduff", 
          "given_name": "Barry", 
          "note": "Main", 
          "start_date": "2017-06-09"
        }
      ]

It looks like these were a result of merging two prior records in https://github.com/mysociety/parlparse/commit/41ab489c

I'm not sure if that was manual or scripted, but if the latter, it might be worth also checking for things like this in the script as well as fixing this specific case.