search

mysociety / planningalerts-app

Find out and have your say about what's being built and knocked down in your area.
www.planningalerts.org.au
Other
0 stars 1 forks source link

Better theme specs (including specs that cover views) #176

Closed lizconlan closed 9 years ago

lizconlan commented 10 years ago

Fix the spec theme mechanisms and stop the main app specs from loading the theme customisations Closes #89

Fix a view bug - and test it! - that prevented the number of matching applications from showing in the search results sidebar Closes #175

Add some feature-style specs for the views (ongoing) Closes #140

stevenday commented 10 years ago

Not sure how finished this is, so ignore me if I'm not helpful, but I think some of the integration tests need to do something with Sphinx because I get errors about it if it's not running: http://pat.github.io/thinking-sphinx/testing.html#unit_tests

I also get some failing tests on the core specs, which look like very minor html changes to static map images, so I wonder whether the easiest thing to do would be to find and undo whatever tweak we've made that makes that happen (if we've actually done anything).

lizconlan commented 10 years ago

Had missed the ThinkingSphinx bit, thanks. Have (hopefully) fixed those within the theme specs.

I'm in 2 minds about whether to fix the core spec failures or to see whether the unmerged OpenAustralia commits will have an effect. Rerunning the core specs for a closer look.

[edit: the core spec fixes were quite simple in the end and only one is definitely solved by an unmerged commit so there's no great harm in including it, fixed in 9d35925]

stevenday commented 9 years ago

Looking good! All the specs pass for me, although I had to turn off the :new_episodes setting for VCR on some of the specs to make sure it used your ones (and have the right dummy htauth credentials in test.yml). I've committed that fix, up to you whether you squash it into the original or not.

:ship:

lizconlan commented 9 years ago

ugh, thought I'd fixed the :new_episodes stuff - thanks!

On 27 November 2014 at 13:19, Steven Day notifications@github.com wrote:

Looking good! All the specs pass for me, although I had to turn off the :new_episodes setting for VCR on some of the specs to make sure it used your ones (and have the right dummy htauth credentials in test.yml). I've committed that fix, up to you whether you squash it into the original or not.

[image: :ship:]

— Reply to this email directly or view it on GitHub https://github.com/mysociety/planningalerts-app/pull/176#issuecomment-64789376 .