search

mysociety / pombola

GNU Affero General Public License v3.0
65 stars 41 forks source link

move breadcrumb generation from a template filter to the view #1362

Open mhl opened 10 years ago

mhl commented 10 years ago

As suggested in 784d073d01535554a49d94724d6e994008a12803 - this could initially be a breadcrumb CBV you can use as a mixin, then customizing it where required by overriding its methods.

chrismytton commented 8 years ago

Having just done some changes on the breadcrumb code I would highly recommend throwing away all of the current code that deals with breadcrumbs as it seems broken beyond repair.

It seems that the simplest/most robust approach would be to simply hardcode the breadcrumbs in the templates that need it.

tmtmtmtm commented 8 years ago

Or, just turn them off entirely (as Mzalendo has already done)