[ZA] Simplify province pages

[zarino]

Based on comments from Gaile and Rashaad about "province pages" like https://www.pa.org.za/place/eastern-cape/ …

• The “People / Constituency Offices” tabs are broken (they don‘t look like tabs at all!) – Megan suggests dropping the “tabs” concept entirely, and just have the people list/accordion always visible, meaning we don’t need a “people” tab at all.
  • Effectively we’d be combining /place/<name> and /place/<name>/places so that people and places are always included on the same page all the time (but folded away nicely in the accordion, as currently).
  • Need to check performance implications of this. Will the server be able to render both sets of data quick enough?
  • Will probably need some developer time, for combining the Django views.
• It’s not made very clear that—for example—“Members of the Provincial Legislature (63)” contains past members as well as present members – Megan suggests breaking past/present out into separate accordion sections?
• They want to rename those accordion links so they’re no longer all “Members of…”. New wording:
  • Members of the Provincial Legislature
  • National Assembly members from provincial list
  • Permanent Delegates to National Council of Provinces
• Remove the “Expand all subsections” link and the “There are 121 people related to…” sentence.
• Remove grey lines beside Constituency Office list items.
  • I think they’re there because the template is trying—and failing—to print out the people related to that location?

[zarino]

2494 has done some work towards tidying up the bottom half of this page, by fixing the tab styling and removing the summary row:

Still to do (as above):

• Show both people and offices on the same page
• Split out historical memberships
• Rename the memberships
• Remove the grey lines beside office list items

[chrismytton]

PMG have asked if it's possible to get rid of the whitespace to the right of the Google Map?

[zarino]

PMG have asked if it's possible to get rid of the whitespace to the right of the Google Map?

It is annoyingly difficult to do. Under the hood, the place pages are use the same layout at the person pages, where the person’s photo is floated left, name and details floated right, and then the rest of the page content continues below them.

The layout is less noticeable on person pages, because the person’s name is followed by one or more contact buttons, which fill the vertical space to the side of the photo, and then the photo itself is followed by a sidebar of contact details, again filling up space.

The only way to remove this space from the place pages would be to have them no longer inherit the person page layout. It’ll be a fair chunk of work, but maybe worth it? Could be something to discuss on our next monthly call, @GeorgieBurr?

[GeorgieBurr]

The call is in another 2/3 weeks from now... do you think it could wait until the call to be discussed? I have added it to the agenda :)

[GeorgieBurr]

Action break up into smaller tickets:

• Show both people and offices on the same page - dev ( 1 day)
• Split out historical memberships - dev (extra time added for Chris to 2- 3days and then 3- day design) - an opportunity for zarino and Chris to pair on this
• Rename the memberships - dev (1 day)
• Remove the grey lines beside office list items - design (1 day)

[chrismytton]

• They want to rename those accordion links so they’re no longer all “Members of…”. New wording:
  • Members of the Provincial Legislature
  • National Assembly members from provincial list
  • Permanent Delegates to National Council of Provinces

This has been done in https://github.com/mysociety/pombola/pull/2544.