search

mysociety / pombola

GNU Affero General Public License v3.0
65 stars 41 forks source link

2646 pre and post 2019 election attendance #2647

Closed xybrnet closed 5 years ago

xybrnet commented 5 years ago

This is a bit ugly, but we need to differentiate 2019 attendance between pre- and post-election records, the dividing date being the opening of the 6th parliament, 1 July 2019.

The PMG API returns annual data from 1 Jan - 31 Dec, so if the user has selected to view records for 2019 (which is the default view for the page until there we receive records for 2020), we divide the results into those before and after 1 July 2019 return the selected records.

xybrnet commented 5 years ago

Thank you for catching that @chrismytton. I've updted first commit to include the fix.

chrismytton commented 5 years ago

Thank you for catching that @chrismytton. I've updted first commit to include the fix.

Thanks! Will take another look at this today.

chrismytton commented 5 years ago

@xybrnet This has now been deployed to the live site: https://www.pa.org.za/mp-attendance/

xybrnet commented 5 years ago

Thank you for pushing this out @chrismytton!