search

mysociety / pombola

GNU Affero General Public License v3.0
65 stars 41 forks source link

disqus not correctly identifying pages #421

Closed evdb closed 11 years ago

evdb commented 11 years ago

need to implement disqus_identifier as documented here: http://help.disqus.com/customer/portal/articles/472098-javascript-configuration-variables.

disqus regard http://info.mzalendo.com/person/charity-ngilu/ and http://info.mzalendo.com/person/charity-ngilu/?gclid=CKWJy-fJsrICFcYMfAodeRQArA as different pages

evdb commented 11 years ago

Have contacted Disqus asking about how we should migrate:

Hello,

We'd like to apply this change to our site:

https://github.com/mysociety/mzalendo/commit/fd5521ff22608ec3f2a943cce7774d66fa382fe0

Basically this changes the comments from being keyed on the page url to being keyed on the disqus_identifier provided.

Can the migration tools be used to make this change? Ideally I'd like to use the CSV mapper to map the currently stored URLs to the newly created identifiers, but I can't see anything about this on http://help.disqus.com/customer/portal/articles/286778-using-the-migration-tools

Or is the solution to export the comments, convert them and then re-import to a new disqus account?

For reference this is Case #163211​​​

evdb commented 11 years ago

Added config option to preserve old behaviour: https://github.com/mysociety/mzalendo/commit/78700f118ba686cd883fffcc18852ad9d1100edc

evdb commented 11 years ago

Response from Disqus:

If you’re simply looking to add a disqus_identifier, then go ahead and include it in the embed code and it will automatically be added to the thread which is already created. You can see the identifiers assigned to a thread using the threads/details method within our API. http://disqus.com/api/docs/threads/details/

I think this will need a little more looking into. Perhaps it will just work?

Either way I think that a url migration would be appropriate to move things from /blah?foo=1 to /blah. There is the ability to download all current urls knows as CSV so doing this conversion should be trivial.

evdb commented 11 years ago

All for MzKe:

I've taken a backup of the disqus comments, and am now running a migration to clean up most of the urls.

When we flip the site over to use the new identifying code we'll probably have to do this again, but it should be a quick task as the bulk should have been cleaned up this pass.

evdb commented 11 years ago

Am about to create a management script that will convert the CSV that disqus provide into one that we can upload to correct all the urls.