search

mysociety / popit-api

DEPRECATED - Development on PopIt has stopped and it is no longer being maintained
https://goo.gl/Vvej4Q
Other
17 stars 3 forks source link

Preserve ?embed and ?q parameters when paginating #114

Closed chrismytton closed 9 years ago

chrismytton commented 9 years ago

When paginating we don't want to keep all parameters because it can cause issue with jQuery's JSONP functionality (see 186c09bf738e4299bf4386864e3cd02e4cc6b7b5).

We do however want to keep user supplied parameters such as how many results per_page, what to embed and the q parameter for the current search.

This ensures that these parameters are kept and makes it easy to add other parameters to keep in the future.

Fixes #110

struan commented 9 years ago

Small issue with empty embed param but otherwise this looks ok.