search

mysociety / popit-api

DEPRECATED - Development on PopIt has stopped and it is no longer being maintained
https://goo.gl/Vvej4Q
Other
17 stars 3 forks source link

id in image url isn't properly escaped #137

Open chrismytton opened 9 years ago

chrismytton commented 9 years ago

e.g. on https://chrism.popit.mysociety.org/api/v0.1/persons/http%3A%2F%2Fwww.senedd.assembly.wales%2FmgUserInfo.aspx%3FUID%3D154 the only object in the images array has a url property of 

https://chrism.popit.mysociety.org/persons/http://www.senedd.assembly.wales/mgUserInfo.aspx?UID=154/image/55045940651ab719723ce04f

which 404s. It should actually be

https://chrism.popit.mysociety.org/persons/http%3A%2F%2Fwww.senedd.assembly.wales%2FmgUserInfo.aspx%3FUID%3D154/image/55045940651ab719723ce04f