search

mysociety / popit-api

DEPRECATED - Development on PopIt has stopped and it is no longer being maintained
https://goo.gl/Vvej4Q
Other
17 stars 3 forks source link

More user friendly search errors #59

Closed chrismytton closed 10 years ago

chrismytton commented 10 years ago

When the search query is invalid show the user a nice message rather than the raw elasticsearch error.

Fixes #52

mhl commented 10 years ago

Looks good - just one query about whether it might be worth getting some more information about the error via the explain parameter and reporting that :+1:

chrismytton commented 10 years ago

@mhl I've added the explain parameter and changed the logic slightly so it returns a 400 status rather than a 500, which seems to make more sense in this context.

mhl commented 10 years ago

@hecticjeff Looks good :+1: