search

mysociety / sobanukirwa-theme

The Alavateli theme for Sobanukirwa (Rwanda)
https://sobanukirwa.rw
MIT License
1 stars 3 forks source link

Add green/yellow/blue line to site-wide navigation #18

Closed StephenAbbott closed 9 years ago

StephenAbbott commented 9 years ago

It would be great to know whether or not we can add a green/yellow/blue line across the site-wide navigation (as per attached design idea) for any users visiting sobanukirwa.rw using wider desktop browser windows. sobanukirwa web design

garethrees commented 9 years ago

I was wondering about this.

I think it might make the navigation bar look slightly odd, as it would break the flow of the current tab in to the page.

screen shot 2014-11-26 at 10 05 22

Perhaps we could add it to the top of the banner rather than the bottom like this:

screen shot 2014-11-26 at 10 17 31

garethrees commented 9 years ago

This is not a huge issue but instead of adding it to the existing navigation design, is there any way to add this coloured line to the bottom of the header background to achieve the same effect?

– Stephen

garethrees commented 9 years ago

We tried a few things:

screen shot 2014-12-11 at 11 30 15 screen shot 2014-12-11 at 11 28 17 screen shot 2014-12-11 at 11 26 27

We thought this one looked the best:

Desktop:

screen shot 2014-12-11 at 11 41 15

Mobile:

screen shot 2014-12-11 at 11 52 21

StephenAbbott commented 9 years ago

Thanks for this, @garethrees. I agree with you. Happy for the green/yellow/blue line to be displayed along the top of the desktop/mobile browser window rather than across top of the navbar.

garethrees commented 9 years ago

Just deployed this.

garethrees commented 9 years ago

Just noticed it looks a little broken when you're logged in as an admin, but is fine for normal users.

StephenAbbott commented 9 years ago

Aha. Was just wondering why I couldn't see this when I was logged in. Looks great when I logged out.