mysociety / theyworkforyou

Keeping tabs on the UK's parliaments and assemblies
http://www.theyworkforyou.com/
Other
224 stars 50 forks source link

Change copy on front pages and about page #1699

Closed ajparsons closed 1 year ago

ajparsons commented 1 year ago

This PR does the following quick changes:

My general approach here is to make an improvement we can come back to later rather than trying to get it perfect now.

Questions:

image

image

image

image

MyfanwyNixon commented 1 year ago

Copy looks fine to me except:

On an entirely personal preference- and I am not a designer - but that light green rather jars for me.

ajparsons commented 1 year ago

Those changes made.

On an entirely personal preference- and I am not a designer - but that light green rather jars for me.

I think it might work a bit better when the white is visible either side (but also it's not ideal!). I'm not opposed to splitting it out as a problem if it becomes a delay but I really don't like the main copy on the homepage of a core service being hard to read, and want a fix (and would personally accept a slightly worse design to improve readability).

image

dracos commented 1 year ago

Probably missed something, but keeping the same green and changing from white to black passes colour contrast check I've just tried? https://webaim.org/resources/contrastchecker/?fcolor=000000&bcolor=62B356

lucascumsille commented 1 year ago

@dracos If we are aiming for a WCAG AAA then we would need to darken the black that we are currently using(#33333) in order to keep the current green on the live website.

lucascumsille commented 1 year ago

Agree with Myf not a huge fan of the green in the hero section as well.

Let me know if any of this sounds good and I can add a commit.

zarino commented 1 year ago

Given #000000 text on the existing #62b356 passes WCAG AA, and we’re after the quickest, simplest fix, I’d go with that.

ajparsons commented 1 year ago

Happy to go with that.

Part of the reason I'm being annoying on the background colour is one of my vision difficulties seems to mean that level of contrast isn't quite enough when there's also a white background on the page (I find it absolutely fine when I use that green all over the page and use black text).

This I find fine:

image

This I find less clear, and that my eye is being drawn off in both directions:

image

Whereas lightening the green fixes that for me. I don't think the standards in this case are picking up the problem I have, so favour even stronger contrasts where possible. I do understand this is a problem that other people literally cannot see though, but I don't think I'm alone in this respect (seems similar to the phantom lines between black text on white background effect).

zarino commented 1 year ago

Yeah, TBH I find the black on green quite low contrast too, even though the WCAG formula is fine with it. These "formula says yes, humans say no" perceptual differences are one of the reasons the (still in draft) WCAG 3 uses a totally different contrast measurement process.

In general I think our rainbow colours are lovely, but we need to come up with some better way of using them on our sites, than as a background for headers and interactive elements, because no matter what colour you lay on top of them (pure black or pure white) the contrast is always rubbish. But that’s a much bigger issue.