Welsh parliament support

mysociety / theyworkforyou

Keeping tabs on the UK's parliaments and assemblies

http://www.theyworkforyou.com/

Other

224 stars 50 forks source link

Welsh parliament support #1700

Closed dracos closed 1 year ago

dracos commented 1 year ago

Fixes https://github.com/mysociety/theyworkforyou/issues/9

(alex edit) Remaining issues:

[x] Primary references to Welsh Parliament
[x] Example postcode in homepage.
[x] Redirect cy homepage to /senedd/ - cy top menu should redirect to english version.
[x] Email templates not in correct place
[x] Outstanding translation issues (tick off when all complete).
[x] Header/Social image for Senedd

Nice to have:

[x] No 'change postcode' option on Senedd page (overall homepage only).
[x] Test for translations.
[ ] Better links from homepage
[ ] ~~Translated/not translated styling~~ (ignoring for now, is okay)

ajparsons commented 1 year ago

Something that would be useful is a test or github action that checks our current translation coverage to make sure we're aware of something failing if we change the text at a later date and open up a problem (had a quick look and I think that's not in the new tests, but could be wrong). I can raise an issue for that at a later date, but if it's easy would be good to have at the start.

ajparsons commented 1 year ago

Looking really good. Signed up for an account and got an email in Welsh - one problem:

The link in the email links to the main (english) version - is that an easy fix?

dracos commented 1 year ago

The link in the email links to the main (english) version - is that an easy fix?

Whoops, yeah, will do a global replace just before emails are sent, is easiest. Also realised that the Eng/Welsh wouldn't work properly on live because it'd try and stick cy. at the start of www. rather than replace it, have put in special case for that.