search

mysociety / theyworkforyou

Keeping tabs on the UK's parliaments and assemblies
http://www.theyworkforyou.com/
Other
226 stars 52 forks source link

Cym - Party names are not translated on Welsh Language pages #1729

Closed it3986 closed 1 year ago

it3986 commented 1 year ago

Names of political parties appear in English on Welsh Language pages about Members of the Senedd. This is despite the Constituency Names having been translated.

Labour => Llafur (or even Llafur Cymru as they are technically members of "Welsh Labour") Conservative => Ceidwadwyr (or Cydwadwyr Cymreig) Liberal Democrat => Democratiaid Rhyddfrydol (or Democratiaid Rhyddfrydol Cymru)

Screenshot of example from https://cy.theyworkforyou.com/mss/?o=f image

dracos commented 1 year ago

Thanks; should now be fixed by bb25a4d57

it3986 commented 1 year ago

Almost... Party names are now in Welsh. However, the classes for the major parties are no longer applying - so Labour and the Conservatives have grey blobs where Plaid Cymru have retained their mustard.

image

Looks like either the English party name needs to be in the class which is currently pulling as people-list__person__party llafur or the CSS needs extending to also apply to the Welsh language party names.

dracos commented 1 year ago

Whoops, ah well, it's one way to have done it I guess! Have extended the CSS rather than cause confusion as to trying to pass through both and missing a translation somewhere.