Remove party cohort code.

mysociety / theyworkforyou

Keeping tabs on the UK's parliaments and assemblies

http://www.theyworkforyou.com/

Other

224 stars 50 forks source link

Remove party cohort code. #1755

Closed dracos closed 4 months ago

dracos commented 6 months ago

We store/use the figures returned externally. Some of the tests are therefore now only testing that what is stored in the fixture is displayed, rather than any calculations involved. Should fix #1742. Is on top of other PRs.

ajparsons commented 6 months ago

This looks good - if you're happy with my amends:

added autocommit settings when loading alignment information to speed that up.
readded vote/division populator for dev setup from json.

dracos commented 5 months ago

Feels like I have to recombine/refactor those two scripts, given how much they do overlap :)

ajparsons commented 4 months ago

Feels like I have to recombine/refactor those two scripts, given how much they do overlap :)

I've recombined these with a switch in a fixup commit - if that's good I can squish before merging.

ajparsons commented 4 months ago

Sure - basically it's a speed of creating a working environment from scratch so the codespace prebuild takes an hour rather than a day.

For debates, I don't mind having a subsection (loading just one month), but for double checking the voting records I want to have all relevant votes, and to do that means downloading and importing thousands of days of debates and votes, which significantly increases the build time.

Ideally, I'd just do that - but given the dev setup was working with the json import, and twfy-votes has continuity with the old format - may as well keep it.

dracos commented 4 months ago

I can't approve my own PR, but happy with it!