ajparsons
commented
3 months ago Ok, I've cleared out that default section. That adds a small menu change that if this was applied on its own would be a problem (doesn't filter to just MPs) - but it'll immediately be joined by the other branch that has tidied that menu up.
If happy with that and the revised commit messages comments above should be addressed.
This supersedes and includes https://github.com/mysociety/theyworkforyou/pull/1756 - rebased over more recent changes.
Basically this is making the "voting summary" page more complete in itself, with better descriptions and better interlinking with the documentation pages.
Update voting infomation page
Building on the change to make this a markdown page - new documentation page reviewed by Myf and Julia (although opinions still welcome).
Always display party comparison information
We always want this information about party to appear - even when there's no actual differences - and link to the info on party comparisons in the help page.
Simplify vote count information
As we now only score strong votes, this is now only counting them here. Because it's harder to do this for the numbers we were showing for the party comparison, I've just taken these out as the two should now be in sync anyway (looking at the same set of votes) - so it can be simplified.
Top level explanation of voting summary
New box to explain the page and link to help pages.
Having little boxes about us in here gives better places for donation asks (which could be bigger than this in future)
Link to feedback form in policy-divisions page
Link to new alchemer form asking for new votes:
Divisions votes side menu doesn't display unnecessary things
Annoyingly this means looping through this twice - but I don't think that's that expensive because it's all already queried..
As some point could just say "this page is only ever for one policy" and get rid of the structure that enables it to do multiple policies. But also, it's messy but fine.
Link to help for informative votes