search

mysociety / theyworkforyou

Keeping tabs on the UK's parliaments and assemblies
http://www.theyworkforyou.com/
Other
226 stars 52 forks source link

Add styles for annotations and video to new debates pages #670

Open wrightmartin opened 10 years ago

dracos commented 10 years ago

Other things currently appearing in the sidebar are the written answer voting, e.g. http://www.theyworkforyou.com/wrans/?id=2014-04-10a.191689.h ; and Scottish question mentions

wrightmartin commented 10 years ago

@dracos So they're missing from the template entirely and needed putting back in?

Can you do this on my vhost and I'll style them up? Thanks

dracos commented 10 years ago

I'm not sure I'm working on this any more at present, sorry, we could have a look on Wednesday though probably. I can't put them in, because I do not know where they are wanted to go. But yes, as with annotations/video, code is present in hansard_gid.php for displaying those things, but is not present in the new template, it should be any bits not commented out in hansard_gid.php as I commented out the bits that were now present.

wrightmartin commented 10 years ago

@dracos Wednesday would be fine, I've got lots of other bits to do before then, thanks!

wrightmartin commented 9 years ago

Annotations are done and tidy, I think we need to discuss the approach with videos, esp. with regard to mobile.

wrightmartin commented 9 years ago

Here's the deal.

On mobile devices (esp those without flash) the video is problematic, firstly in terms of detecting flash support and dealing with it, but also the UX of the read-along functionality, floated video and how it translates to mobile.

It's left me blocked on this one, as I don't think I can decide what to do here without talking to other interested parties.

jacksonj04 commented 9 years ago

In this day and age if we want to do video we have to do it properly - an embedded Flash player isn't going to cut it. Analytics tells me nearly 30% of page views are mobile, and of those a full 60% are iOS. Nearly 1 in 5 users are on a platform which simply doesn't do Flash.

dracos commented 9 years ago

I don't particularly mind the video only working on desktop, given we're not getting any more for some time now, but I just don't want to lose its current behaviour on desktop, given it's a wealth of existing data for those debates it exists for.

wrightmartin commented 9 years ago

@dracos that sounds reasonable, any ideas on how we can prevent the video files downloading or the code executing on mobiles?

dracos commented 9 years ago

Put #video-wrap (etc) inside a media query, so it only displays after a certain width?