search

mysociety / theyworkforyou

Keeping tabs on the UK's parliaments and assemblies
http://www.theyworkforyou.com/
Other
229 stars 53 forks source link

Move puphpet to separate repository #831

Open dracos opened 9 years ago

dracos commented 9 years ago

It is only used by Vagrant, and could be pulled in from a separate repo as the first step of its provisioning, then proceeding as it does currently. It is the fourth largest directory in the repo (perhaps rising to third if updated), much of which is unnecessary (postgres, yum, nginx, etc). When it was originally added to the repo, it was around a dozen files; it's now a few thousand, and yet is not self-contained enough that it doesn't break when something external changes e.g. https://github.com/puphpet/puphpet/issues/1492 currently.

For full benefits, this could be accompanied by a rebase to remove it from the history. This could be accompanied by a move/removal of the unused googleappengine (largest directory) and uml-tests (third largest directory). (Second largest directory is images.)

jacksonj04 commented 9 years ago

The supervisord and php-fpm bugs have now been fixed, so it might be worth doing a general PuPHPet update at the same time.

jacksonj04 commented 9 years ago

See also #845.