Move people list pages to new design

mysociety / theyworkforyou

Keeping tabs on the UK's parliaments and assemblies

http://www.theyworkforyou.com/

Other

226 stars 52 forks source link

Move people list pages to new design #838

Closed struan closed 9 years ago

struan commented 9 years ago

/mps, /peers etc

zarino commented 9 years ago

At the risk of being unoriginal, this could very easily adopt almost the exact same styling as the new Search page, just with downloads listed in the sidebar, and a table of MPs in the main content area.

screen shot 2015-05-19 at 16 57 30

I would make just one feature request – that the "Find your MP" search box at the top performs a search both by postcode and MP name. (This is currently handled by two different search inputs on the existing page).

screen shot 2015-05-20 at 13 08 19

screen shot 2015-05-20 at 13 08 26

dracos commented 9 years ago

The search by name box already accepts a postcode, so that's just copy change and reusing that form rather than the postcode one; and perhaps (given the postcode lookup redirects immediately, whilst name doesn't) having the search results page automatically redirect when given a postcode input (I don't see why it shouldn't)?

zarino commented 9 years ago

@dracos: Ace! I tried a name in the postcode box, and it didn't work. I didn't think to try the other way round!

zarino commented 9 years ago

Decided to timebox this to two hours, just to see how far I could get. The answer is: pretty far. Pull request here: https://github.com/mysociety/theyworkforyou/pull/870