search

mysociety / whatdotheyknow-theme

The Alaveteli theme for WhatDoTheyKnow (UK)
http://www.whatdotheyknow.com/
MIT License
31 stars 26 forks source link

Add UK-specific excluded calculated homepage domains #1789

Closed garethrees closed 1 year ago

garethrees commented 1 year ago

Requires https://github.com/mysociety/alaveteli/pull/7836

garethrees commented 1 year ago

Any more we want to catch? Don't need to be exhaustive at this point, but might have missed a few obvious ones.

gbp commented 1 year ago

@garethrees the specs are failing on this guessing that is because the core PR hasn't been merged. Attempting to run this locally and it doesn't seem to be working, am I missing something?

gbp commented 1 year ago 
[1] pry(main)> PublicBody.excluded_calculated_home_page_domains
=> ["aol.com",
 "gmail.com",
 "googlemail.com",
 "gmx.com",
 "hotmail.com",
 "icloud.com",
 "live.com",
 "mac.com",
 "mail.com",
 "mail.ru",
 "me.com",
 "outlook.com",
 "protonmail.com",
 "qq.com",
 "yahoo.com",
 "yandex.com",
 "ymail.com",
 "zoho.com",
 ["aol.co.uk",
  "blueyonder.co.uk",
  "btconnect.com",
  "btinternet.com",
  "btopenworld.com",
  "hotmail.co.uk",
  "live.co.uk",
  "ntlworld.com",
  "sky.com",
  "talk21.com",
  "talktalk.net",
  "tiscali.co.uk",
  "virginmedia.com",
  "yahoo.co.uk"]]
garethrees commented 1 year ago

Ah, woops!