[#1822] Add template for immigration correspondence (ATAS)

mdeuk commented 10 months ago

Relevant issue(s)

Fixes #1822 Depends on https://github.com/mysociety/alaveteli/pull/8121

What does this do?

This adds a new template Immigration correspondence (ATAS) which displays on requests made to body 93723 (FCDO).

Why was this needed?

There has been an uptick in requests to the FCDO which concern a specific immigration matter (ATAS), and this is not covered by the existing messages for this body.

Implementation notes

Nothing special to note.

Screenshots

Notes to reviewer

When testing this on a sandbox, I'm getting a weird glitch where it looks like every line is double spaced (e.g. \n\n). I think this is a problem with my environment, as it does the same with others (e.g. _subject_access_request), but it seemed worth noting anyway.

mdeuk commented 10 months ago

Sorry, looks like my base was out of date - despite git originally claiming otherwise. Hopefully I've not broken anything.

gbp commented 9 months ago

Screenshot:

Admin

Request after being hidden

Email

WilliamWDTK commented 9 months ago

There are a few textual changes I would make, referencing the parts marked in red in the image above (and text just by that section).

circumstances, via → circumstances via
needWhatDoTheyKnow: add line-break
Foreign, Commonwealth, and Development Office → at least Foreign, Commonwealth and Development Office, but ideally match official name and WDTK listing with Foreign, Commonwealth & Development Office
directly, at: atas@fcdo.gov.uk: might want to remove colon, and add a full stop at the end of the line, that's possibly personal preference.
MPs offices can ask the FCDO → MPs' offices can ask the FCDO
You will still be able to view it while logged in to the site. → You will still be able to view the request while logged into the site. (The mention of hiding was much earlier, so it's not clear what it is referring to, also in to → into.)