Attachment to HTML view displays old logo

[garethrees]

https://www.whatdotheyknow.com/request/401913/response/983427/attach/html/4/REQ02625.pdf.html

APP_USER@FILTERED:/FILTERED/www.whatdotheyknow.com/alaveteli$ ls -al public/assets/ | grep logo-trans-small
-rw-r--r--  1 foi foi   3398 Mar 15 11:28 logo-trans-small-0170b7dd91ad829fccbdbbfefd2b41cce4949b1af0c66907c96e0b7397cf9a3b.png
-rw-r--r--  1 foi foi   3398 Mar  8 11:59 logo-trans-small-6359f2644f0b9905004bc0fee0efdb47.png
-rw-r--r--  1 foi foi   4445 Jul  7  2016 logo-trans-small-6ee7375d59a66eb2ffab5796ea4294ad.png
-rw-r--r--  1 foi foi   4445 Sep 25  2014 logo-trans-small-aff6de8063c4255a82ee90c1c16830f4.png
lrwxrwxrwx  1 foi foi    132 Jul  3 09:20 logo-trans-small.png -> /data/vhost/www.whatdotheyknow.com/alaveteli-2017-07-03T08-17-10/public/assets/logo-trans-small-aff6de8063c4255a82ee90c1c16830f4.png

I'm not 100% sure of what's going on here, but I think the problem is that _view_html_prefix.html.erb isn't using an asset helper, so not getting linked to the correct logo version.

There might be other things at play.

• wdtk-theme has a logo-trans-small.png in assets https://github.com/mysociety/whatdotheyknow-theme/blob/master/app/assets/images/logo-trans-small.png – shouldn't be a problem though because we should be looking for the one in navimg.
• I don't know where that particular version of the logo is coming from. Might be cached somewhere.

[mdeuk]

This bug is back again - with an even older logo!

For example, on a pretty recent response to 851068, the html render of a PDF in imsg 2027866 is displaying the old logo.

Has something snuck back in during infrastructure migration? My reason for pondering that is, we're rendering the logo from /assets/navimg/logo-trans-small.png- but, the corresponding file in the codebase is not the same.

It's worth noting, perhaps, that this one does seem to be the same logo as is in the codebase at /app/assets/images/logo-trans-small.png.