search

mysociety / whatdotheyknow-theme

The Alaveteli theme for WhatDoTheyKnow (UK)
http://www.whatdotheyknow.com/
MIT License
31 stars 26 forks source link

Requests submitted in a localised language contain incorrect boilerplate #510

Open mdeuk opened 6 years ago

mdeuk commented 6 years ago

When a request is being submitted using /cy the boilerplate text in the email generated to the authority contains some text which is not being localised, namely, our links to ICO guidance, and, our notice regarding delayed publication.

screenshot 2018-09-30 at 1 17 07 am

These notices appear to be generated from lib/views/outgoing_mailer/_followup_footer.text.erb, however, I am filing on wktk-theme as the linkage to the ICO appears to be contained within the theme itself (per #279), rather than within the translation files upstream.

Is it possible to source Welsh translations for both the text "For more detailed guidance on safely disclosing information, read the latest advice from the ICO", and, the pro text (contained in the upstream source) "Please note that in some cases publication of requests and responses will be delayed."?

lizconlan commented 6 years ago

Hmm, looks like that's a theme-level translation but - as far as I can see - we don't have a Transifex project for the whatdotheyknow-theme

mdeuk commented 6 years ago

Hmm, looks like that's a theme-level translation but - as far as I can see - we don't have a Transifex project for the whatdotheyknow-theme

That's what I thought too! The first part seemed to be hard coded in _followup_footer.text.erb without a corresponding entry in the translation file upstream - however - the second part (e.g. the pro text) does seem to emanate from the upstream. How very curious 🙂