search

mysociety / whatdotheyknow-theme

The Alaveteli theme for WhatDoTheyKnow (UK)
http://www.whatdotheyknow.com/
MIT License
31 stars 26 forks source link

Add new invalid address to model_patches.rb #778

Closed RichardTaylor closed 3 years ago

RichardTaylor commented 3 years ago

Address: foi&dparequest@nmc-uk.org

Issue occurred at https://www.whatdotheyknow.com/request/non_represented_nurses_and_midwi#incoming-1729573

Related Alaveteli issue: https://github.com/mysociety/alaveteli/issues/3465

mdeuk commented 3 years ago

I think @MattK1234 already fixed this in #771 - please reopen if that’s not the case.

RichardTaylor commented 3 years ago

The fix presumably wasn't live on WDTK at the time the issue I reported occurred.

I suspect we were, and maybe still are, awaiting deployment?

RichardTaylor commented 3 years ago

An issue apparently related to this occurred on the 10th of March 2021 at

https://www.whatdotheyknow.com/request/length_of_time_to_provide_eviden#outgoing-1123705

Is this because the incoming message in question came in prior to the fix being deployed? Has the change been deployed?

mdeuk commented 3 years ago

@gbp Looks like this was merged into master as 2bcc47f on 16 Feb - are you able to advise when it would have been pushed onto the production system?

I wonder if we're dealing with a new issue here, or if it's just a glitch.

gbp commented 3 years ago

@mdeuk Last WDTK deploy was on 18 Feb. So the change would've been included then.

MattK1234 commented 3 years ago

Tested this today and it looks like the patch is working so closing.