WIP: HTML email markup and styling

[zarino]

Fixes #164.

To do:

• [x] Designer – HTML template and styling
• [x] Designer – Litmus testing
• [x] Designer – create a template for each existing WTT email
• [x] Developer – Code to construct multipart emails out of HTML template and plain text alternative
• [x] Developer – Code to attach logo.gif and wire up cid img src

See how they look on Litmus:

Confirmation: https://litmus.com/pub/40b8db9

Questionnaire: https://litmus.com/pub/f4c6538

Autoresponse: https://litmus.com/pub/974976e

[jacksonj04]

nb: last time I looked at this the library we use to do emails doesn't happily play with multipart, although newer versions/alternatives are available which (in theory) do so nicely.

[zarino]

@jen @tmtmtmtm: This is ready for a developer to look at now.

[struan]

Plan:

• [x] Convert existing email construction to use Email::Mime
  • [x] confirmation email
  • [x] representative email
  • [x] questionnaire email
  • [x] failure email
• [x] Generate HTML templates
  • [x] confirmation email
  • [ ] representative email?
  • [x] questionnaire email
  • [x] failure email?
• [x] create multipart email with text and HTML versions
  • [x] confirmation email
  • [ ] representative email?
  • [x] questionnaire email
  • [x] failure email?

[zarino]

Here's how it's looking for me, after the fixes in https://github.com/mysociety/writetothem/pull/342/commits/95fa9993bff7aa7d31bdcb5d98a7bd99ea5fc29d – https://litmus.com/pub/405e5f3

[struan]

Confirmation email results at:

https://litmus.com/checklist/public/c1cf58b

And the questionnaire email is:

https://litmus.com/checklist/public/0de477c

Things to fix/investigate:

• [ ] Android email width
• [ ] Missing imaged on Android/Gmail although this may just be how they work
• [x] line break in support address at bottom of the email

[dracos]

There is a test site on firefly, run with mysociety test writetothem (having this run on travis would be nice wouldn't it...). It gives a warning of uninitialized value $FYR::EmailSettings::td_style at FYR/EmailSettings.pm line 61 (looks like $td_style is used without being defined). It then dies because it can't find the confirmation email, I think because it is yucky and does it with text search and the To and Subject lines are now the other way round, so I think all the email checking calls will need updating before the test suite passes and this can be fully reviewed.

You'll also want to be deleting the AOL special handling that will corrupt these new emails :)

[TomSteinberg]

I have a age-old desire to know what the performance change is, once this is applied. Do please tell...