search

mysociety / writetothem

Write to your MP, MEP, & other elected representatives.
https://www.writetothem.com
Other
54 stars 11 forks source link

Increase grid gutter to 32px, to avoid scroll overflow bug in footer #466

Closed zarino closed 3 years ago

zarino commented 3 years ago

Some of the footer elements create a -16px margin, to horizontally align child elements. But in combination with WriteToThem’s 15px gutters, this was causing a 1px horizontal scroll overflow on narrow screens.

Bumping the Foundation gutter setting up from 30px to 32px fixes it, and the 2px difference in grid spacing is effectively unnoticeable.

zarino commented 3 years ago

Or set $column-gutter to 2em/32px in WTT variables? :)

Dammit @dracos why didn’t I think of that.

Have dropped the standard-footer changes, and just made the gutter change, as suggested.