search

mysociety / writetothem

Write to your MP, MEP, & other elected representatives.
https://www.writetothem.com
Other
54 stars 11 forks source link

More helpful contact page #467

Closed zarino closed 3 years ago

zarino commented 3 years ago

Fixes #369.

Branched off the 309-development-environment branch from #464.

@dracos I notice, in addition to the regular contact page at about-contact.html, there’s an about-contactresponse.html file. Do you know where this gets used?

Screenshot_2021-02-10 WriteToThem

Screenshot_2021-02-10 WriteToThem(1)

Screenshot_2021-02-12 WriteToThem(1)

Screenshot_2021-02-12 WriteToThem

dracos commented 3 years ago

It's the page when you submit the form on the contact page.

zarino commented 3 years ago

@dracos I think this is ready for review now!

zarino commented 3 years ago

@dracos Fixed! Happy for all of this to be merged into master (including @sagepe’s earlier Docker commits)? Or should I rebase those out?

sagepe commented 3 years ago

There is a separate PR for the Docker commits (#464), so perhaps we should treat them separately 🤷🏻

Also, if you (@zarino ) have used the environment, perhaps you'd be better placed to complete that review instead of @wrightmartin?

zarino commented 3 years ago

Thanks @sagepe. Have left a review on https://github.com/mysociety/writetothem/pull/464 :+1: