search

mysociety / yournextrepresentative

A website for crowd-sourcing structured election candidate data
https://candidates.democracyclub.org.uk/
GNU Affero General Public License v3.0
56 stars 21 forks source link

take the site name from the sites framework, not localised strings #506

Closed mhl closed 9 years ago

mhl commented 9 years ago

At the moment, if you view https://edit.yournextmp.com with es first in your Accept-Language header, you'll see the site in Spanish, but its name will shown as "Yo Quiero Saber" rather than "YourNextMP". To fix this, I think that uses of the site name in translated strings should come from an interpolated variable which is taken from the name set in the sites framework.

martinszy commented 9 years ago

A related issue.

For instance, in this page: http://investigacion.yoquierosaber.org/help/privacy

With the browser in English you get the message: "This site is run by Democracy Club."

And in Spanish you get: "Este sitio es posible gracias a la colaboración de Congreso Interactivo, OpenKnowledge Argentina, Taringa, HacksLabs, We-Me y muchos voluntarios como vos."

Since this strings represent different partnerships to run de site in different countries, they should not be dependent entirely on the translations. Or maybe there should be some translated strings per-election.