Open mhl opened 8 years ago
It would also presumably avoid the issue of what are essentially blessed election slugs being used by other people and unexpected things happening when they ran migrations.
Just for the record, this approach combined with #653 would make re-deployment quite a bit simpler and would allow a deployed instance to be pegged to a release that would just "work" until a maintainer got around to updating to a newer YNR release.
@evz suggested that it would be easier to reuse YNR if the code specific to a particular country was in its own repository, which then used the core YNR Django code as any other django-application installed from PyPi. As an example, datamade took this approach for councilmatic:
There are various advantages from our point of view to having all the countries in one repository. e.g. those that occurred to me when discussing this earlier were:
On the other hand, reusers of the code are left with some not very appealing options to work on their own version of the site, basically either:
Making YNR a django application which is on PyPi and easily reusable by country-specific sites / repositories would mean that neither of those are an issue, and more generally seems like a better architecture.
I'm not really sure how much work would be involved in this refactoring, however, so I'm suggesting a two day spike to see how hard it would be.