search

mysociety / yournextrepresentative

A website for crowd-sourcing structured election candidate data
https://candidates.democracyclub.org.uk/
GNU Affero General Public License v3.0
56 stars 21 forks source link

Fix "finder" styling on non-UK homepages #834

Closed zarino closed 8 years ago

zarino commented 8 years ago

3597b7e3022d9748422b45942077ca684b1a555f edited the _finder.scss styles in core, when really it should have been a UK-specific change.

This commit reverts those changes to core _finder.scss, and moves the .finder__forms__container and other related changes into a UK-specific override of the _finder.scss stylesheet.

Fixes #831.

Before:

screen shot 2016-04-15 at 13 24 02

After:

screen shot 2016-04-15 at 13 23 12

@mhl – could you give this a review? I've tested it locally by switching to the uk country, but all I see on the homepage is the location search form, rather than the extra stuff that’s visible on https://candidates.democracyclub.org.uk. I’m assuming there's some democracy club magic that I'm missing?

mhl commented 8 years ago

Thanks, @zarino - I've tried the front page in all the current countries, and then merged this into DC master to see if it works there too. Everything looked good :) :+1: