search

mysociety / yournextrepresentative

A website for crowd-sourcing structured election candidate data
https://candidates.democracyclub.org.uk/
GNU Affero General Public License v3.0
56 stars 21 forks source link

Various template fixes #839

Closed wfdd closed 8 years ago

wfdd commented 8 years ago

Attribute/dict access doesn't work inside blocktrans.

wfdd commented 8 years ago

For instance [1]:

Oh no! We don’t know of any candidates from for Member of the Scottish Parliament for Central Scotland for the 2016 Scottish Parliament Election (Regions) yet.

That should be:

Oh no! We don’t know of any candidates from Beaconsfield Independent Electors Association for Member of the Scottish Parliament for Central Scotland for the 2016 Scottish Parliament Election (Regions) yet.

https://docs.djangoproject.com/en/1.8/topics/i18n/translation/#std:templatetag-blocktrans

wfdd commented 8 years ago

I've pushed another commit in the same vein. The site name was missing from the first sentence in /tasks/ (see https://candidates.democracyclub.org.uk/tasks/).

wfdd commented 8 years ago

Okay, I've pushed another unrelated fix so I'm renaming this to something suitably vague.

In relation to this fix, see https://groups.google.com/forum/#!search/urls$20in$20%7B$25$20blocktrans$20$25%7D$20fails$20silently./django-developers/FSj71k9Qup4/sE0qraXgCtYJ.

mhl commented 8 years ago

:+1: This all looks good, thank-you - I've rebased and then merged to keep the history simpler.