mysociety / yournextrepresentative

A website for crowd-sourcing structured election candidate data
https://candidates.democracyclub.org.uk/
GNU Affero General Public License v3.0
56 stars 21 forks source link

Bulk add candidates: ability to see/add/amend Additional Name(s) inline #983

Closed jf1 closed 7 years ago

jf1 commented 7 years ago

Re. #840 the ability to see/add/amend Additional Name(s) inline was suggested by @symroe on Slack:

On bulk adding: AJAX editing of person names. It takes a long time if an alternative name on the SOPN needs adding because you have to go in to each candidate. This breaks the SOPN flow. Something that lets people edit names inline would be really handy

nb. The need to consider cases where candidates have existing Alternative Name(s).

It'd also be helpful if DC had a policy for preferred names - I suggest we should encourage: Name = Firstname Lastname unless they're publicly known as something else, then: Alternative Name = Firstname Middle-name(s) Lastname (ie formal name as printed on the SoPN).

I put an example in 787 (but don't want to link there is case there's other irrelevant stuff in that issue): Examples from GM Mayor include: (Fine in DC) Sean Anstee - this is how people know him; his full SoPN name is Sean Brian Anstee. (Weird in DC) Jane Elisabeth Brophy - this is her full/formal name, but she's always known and promoted as Jane Brophy

symroe commented 7 years ago

This would speed up the adding of candidates at the end of this week, so I think this is a good contender for work this week.

mhl commented 7 years ago

To add an example to this, on a page like: /bulk_adding/nia.2017-03-02/osni_oid:NIE-18/:

alternative-name-adding

The existing candidates listed there just have an edit button beside them, and going through that "Edit" to add the variant of the name which is on the ballot paper (which often have more middle names, etc.) is badly distrupting the flow of adding data from nomination papers.

Perhaps the simplest way to deal with this would be to:

zarino commented 7 years ago

We’ve started this in branch DemocracyClub:bulk-edit-alt-name-editing

struan commented 7 years ago

Fixed in https://github.com/DemocracyClub/yournextrepresentative/commit/cd5a7187bcbe36de2a3aa5feedc976bdf9efe956