Three fields which are currently in SiteSettings shouldn't be - they're used by core Django, so we can't easily modify that code to use a value from SiteSettings instead:
DEFAULT_FROM_EMAIL
SERVER_EMAIL
DATE_FORMAT
These should be removed from SiteSettings.
The following remaining settings are OK to handle as values of SiteSettings, but I've spotted many instances in the code when their value from django.conf.settings is used instead of SiteSettings - these all need to be checked, and any wrong ones fixed:
Three fields which are currently in SiteSettings shouldn't be - they're used by core Django, so we can't easily modify that code to use a value from SiteSettings instead:
DEFAULT_FROM_EMAILSERVER_EMAILDATE_FORMATThese should be removed from
SiteSettings.The following remaining settings are OK to handle as values of
SiteSettings, but I've spotted many instances in the code when their value fromdjango.conf.settingsis used instead ofSiteSettings- these all need to be checked, and any wrong ones fixed:SITE_OWNERSITE_OWNER_URLCOPYRIGHT_HOLDERTWITTER_USERNAMESUPPORT_EMAILDD_MM_DATE_FORMAT_PREFERREDMAPIT_BASE_URLGOOGLE_ANALYTICS_ACCOUNTUSE_UNIVERSAL_ANALYTICSNEW_ACCOUNTS_ALLOWEDHOIST_ELECTED_CANDIDATESRESTRICT_RENAMESEDITS_ALLOWEDCANDIDATES_REQUIRED_FOR_WEIGHTED_PARTY_LISTTWITTER_APP_ONLY_BEARER_TOKENIMAGE_PROXY_URL