search

mysociety / za-hansard

A parser for South African Hansards, as published at http://www.parliament.gov.za/live/content.php?Category_ID=119
Other
2 stars 3 forks source link

Committee notifier #54

Open geoffkilpin opened 10 years ago

geoffkilpin commented 10 years ago

Creates a scraper for Parliament's Announcements, Tablings and Committee Reports documents and searches these for announcements of changes to committee membership. If an announcement is found, an email is sent to an address specified in the Pombola configuration file (see mysociety/pombola#1488)

mhl commented 10 years ago

Hi @geoffkilpin - sorry for not dealing with this for so long, please hassle me if a pull request hasn't been reviewed within a couple of days!

I've left a few comments, the only really significant one is a suggestion to factor out the duplicate code in retrieve_sources. (There are quite a few minor PEP 8 things as well, but I didn't think it was worth mentioning all of those - PyLint should point them out.)

duncanparkes commented 10 years ago

Hi @geoffkilpin, @mhl - I would recommend using flake8 https://pypi.python.org/pypi/flake8 to check for PEP8 type things. PyLint has so much to say it's hard to find the useful bits...