myspaghetti / macos-virtualbox

Push-button installer of macOS Catalina, Mojave, and High Sierra guests in Virtualbox on x86 CPUs for Windows, Linux, and macOS
GNU General Public License v2.0
13.5k stars 1.12k forks source link

Fix up dmg2img for some versions (Linux) #478

Closed dvershinin closed 3 years ago

dvershinin commented 3 years ago

The script quickly failed on me with "Please install the package dmg2img." even the program was in my PATH and all.

It's simply because (maybe my specific version) dmg2img emitted its entire help output to stderr.

I think the right way is to simply check the exit code instead of output. Tested on RHEL 8.