myspaghetti / macos-virtualbox

Push-button installer of macOS Catalina, Mojave, and High Sierra guests in Virtualbox on x86 CPUs for Windows, Linux, and macOS
GNU General Public License v2.0
13.5k stars 1.12k forks source link

Highlight need for CygWin on Windows in README or script #497

Closed jmynes closed 3 years ago

jmynes commented 3 years ago

I had to read through (closed) Issue #426 before I realized I wasn't reading the README carefully enough.

The script seems to hang indefinitely when I let PowerShell or Git Bash try to handle things, but runs quickly and flawlessly on Cygwin.

Alternatively, adding a printout comment in the script that reminds people it's tested only for Cygwin (on Windows) may be just as useful, as it was otherwise difficult to figure out what was causing it to fail (such as missing dependencies, etc)

jmynes commented 3 years ago

Also, there's a typo "supprort" in the CPU section of the documentation.

myspaghetti commented 3 years ago

The typo was fixed over a month ago, I hope there isn't an old version of the script floating around on the internet.

The very first line in the readme is "macos-guest-virtualbox.sh is a Bash script", I see no need to mention that Bash scripts do not work on cmd.exe or PowerShell. Git-Bash might be confusing to some but I think it's on Git to explain that Git-Bash is not Bash, but only a Git environment that behaves like Bash.