Closed slowpeek closed 2 years ago
Are you sure you've read into the PR text and the code? The very first line says:
$stages
and$specified_arguments
are ARRAYS now (were strings).
Hence your objections are irrelevant.
Perhaps your bash is configured differently than the default? By default bash treats a string in quotes as a single parameter. Plus I'd like to preserve zsh compatibility.
You've got wrong every single word I've said.
Did you forget to commit the change that made them into arrays?
Oh would you look at that, they're arrays. Huh.
Oh would you look at that, they're arrays. Huh.
Haha, yeah. Thats what the PR message says.
Changes:
$stages
and$specified_arguments
are arrays now (were strings).Improvements:
$other_commands
array. It is used both in valid commands check and in the 'unrecognized argument' error message. Previously they were listed literally in both places.Btw I intentionally dont quote the left side in
[[ $a == "$b" ]]
conditions. It is not required in bash. As for zsh I refer to this piece from the docs: