search

myspaghetti / macos-virtualbox

Push-button installer of macOS Catalina, Mojave, and High Sierra guests in Virtualbox on x86 CPUs for Windows, Linux, and macOS
GNU General Public License v2.0
13.5k stars 1.12k forks source link

Add extra comments and add 256MB VRAM Option #570

Closed ssavva05 closed 2 years ago

myspaghetti commented 2 years ago

Thanks for the contribution but I decided not to merge the pull request:

  1. Loading foreign kext files can be quite tricky and I'd rather not even suggest it in the readme
  2. 256MB is indeed the max VRAM, but not on all intallations. The performance difference is negligible I believe, with video performance being throttled by some other factor.
  3. SIP - this is mentioned in the script itself and if some advanced user is looking for it they'll find it.

So while everything in the pull request is correct, I think it's not a good fit for the readme.