search

myspaghetti / macos-virtualbox

Push-button installer of macOS Catalina, Mojave, and High Sierra guests in Virtualbox on x86 CPUs for Windows, Linux, and macOS
GNU General Public License v2.0
13.46k stars 1.11k forks source link

cpu-profile in basic vm configuration setting #633

Closed cederom closed 1 year ago

cederom commented 1 year ago

Hello world :-)

Because OS under VM is picky about CPU it would be really nice to have --cpu-profile setting explicitly set as part of basic VM configuration, right next to CPU Cores, RAM amount, etc. This is a quite trivial change.

How to make this work is described in https://github.com/myspaghetti/macos-virtualbox/issues/589 but this does not quite obviously come from a current documentation that states changes should be performed on a powered off VM and that breaks whole process.

Thanks for considering and Big THANK YOU for this Marvelous Tool! :-)

myspaghetti commented 1 year ago

Glad to hear you found the script useful!

I suppose the documentation could point out that these settings can be modified by modifying the script, too.

myspaghetti commented 1 year ago

Implemented by merging pull request 656

cederom commented 1 year ago

TANK U SIR! :-)