Added `--cpu-profile` config variable

myspaghetti / macos-virtualbox

Push-button installer of macOS Catalina, Mojave, and High Sierra guests in Virtualbox on x86 CPUs for Windows, Linux, and macOS

GNU General Public License v2.0

13.46k stars 1.11k forks source link

Added `--cpu-profile` config variable #656

Closed CompuGenius-Programs closed 1 year ago

CompuGenius-Programs commented 1 year ago

This solves #633, plus also helps not having to run the script, encounter the issue, delete all the generated files (because yep, it'll fail if you run it again without doing so), edit the script and run it again 😅 Awesome tool! Currently running the script - it hasn't completed yet but I'm looking forward to a working macOS installation in VirtualBox!

myspaghetti commented 1 year ago

Adding a default profile will most likely break compatibility with more devices than it'll un-break.

CompuGenius-Programs commented 1 year ago

It can still be added, but commented out by default, no?

myspaghetti commented 1 year ago

Would be better with --cpu-profile host by default so VBoxManage doesn't throw a fit.

CompuGenius-Programs commented 1 year ago

Is this better?