search

mysql / mysql-utilities

MySQL Utilities is a set of easy-to-use scripts intended to make working with MySQL servers easier.
GNU General Public License v2.0
267 stars 161 forks source link

mysqldiff: index filelds misordered bug fix #24

Closed seanlook closed 6 years ago

seanlook commented 6 years ago

  1. in sql_transform.py:_get_index_sql_clauses(), rows parameter must be ordered by index seq_no, since index filelds have order. But when using get_common_lists() to get add/drop index, index fileds are disordered (set() operation) This leads to the wrong index clauses: idx1(f1,f2) is constructed to idx1(f2,f1) probably.

  2. using get_common_lists() to get add/drop index, will missing some index filelds: table1: idx1(f1,f2) table2: idx1(f1) idx1(f2) will be constructed, that's too bad.

mysql-oca-bot commented 6 years ago

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html Please make sure to include your MySQL bug system user (email) in the returned form. Thanks

seanlook commented 6 years ago

I've signed the OCA and sent email. Wait for reply. Thank you.

mysql-oca-bot commented 6 years ago

Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: "I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it." Thanks

mysql-oca-bot commented 6 years ago

Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed. Thanks

seanlook commented 6 years ago

Sorry. Recently I don't find some time to test the code although I user it in my environment. I'll do it in this week