search

mysql / mysql-utilities

MySQL Utilities is a set of easy-to-use scripts intended to make working with MySQL servers easier.
GNU General Public License v2.0
267 stars 161 forks source link

Fix retrieving unicode fields from the server #44

Closed mmuman closed 5 years ago

mmuman commented 5 years ago

I happened to have an accented character in a varchar field here that made mysqldbexport choke with: UnicodeEncodeError: 'ascii' codec can't encode character u'\xe8' in position 10: ordinal not in range(128)

So we check if the value is a unicode string, and if so we encode it back to a UTF-8 string.

Works for me(TM) but I didn't run any other test.

mysql-oca-bot commented 5 years ago

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html Please make sure to include your MySQL bug system user (email) in the returned form. Thanks

mmuman commented 5 years ago

Seriously, for a 2liner? 😒

mysql-admin commented 5 years ago

Hi @mmuman Thanks for your contribution. While there can be cases where specific minor changes are such that an OCA is not needed for them this is not something that can be determined automatically (based on number of lines etc) and requires a manual review. Also an OCA applies to future contributions (not just the specific current one). As such the need to sign an OCA is generic and applies to all contributions regardless of their specifics.

Thanks ==Omer

mmuman commented 5 years ago

Yes I guessed as much. IIRC VirtualBox also accepts contributions explicitly done under MIT license…

mysql-oca-bot commented 5 years ago

Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed. Thanks