search

mysqljs / mysql

A pure node.js JavaScript Client implementing the MySQL protocol.
MIT License
18.22k stars 2.53k forks source link

Renaming #2476

Closed ghost closed 2 years ago

ghost commented 3 years ago

https://github.com/mysqljs/mysql#poolcluster Please make use of provider/consumer or a more neutral naming pair when describing pool cluster configurations. Thank you.

dougwilson commented 3 years ago

Hi @searraschell thank you for your issue report. The PoolCluster was a contribution from a few users and I'm not very familiar with it, including what you mean by your issue. Can you ellaborate more on what you mean? Or perhaps submit a PR for the change you are looking for?

Zikoel commented 3 years ago

I think this is a question of don't use master or slave! To accomplish this is sufficient to rename some words on the readme no code need to be touched.

dougwilson commented 3 years ago

Oh, I see. These are the direct terms used by the MySQL server itself (https://dev.mysql.com/doc/internals/en/replication.html, https://dev.mysql.com/doc/refman/8.0/en/replication-statements-replica.html). If they can provide new terms to use in their literature, we can update them here to match. If they don't match, then we would need to add somewhere in here the mapping, which I think would defeat the purpose as they would still end up in the readme.