search

mysqljs / mysql

A pure node.js JavaScript Client implementing the MySQL protocol.
MIT License
18.31k stars 2.53k forks source link

Update ssl_profiles.js #2569

Open whatadewitt opened 5 months ago

whatadewitt commented 5 months ago

update Amazon RDS profiles to latest

context: working on a project with legacy codebase. need to update to a newer cert by aug 22, 2024. i can use a fork to handle this, but figure it might save some people some of the headaches i've been dealing with.

whatadewitt commented 5 months ago

If this seems ok, let me know and I can submit with an updated version as well.

sidorares commented 5 months ago

@whatadewitt maybe worth switching to https://github.com/mysqljs/aws-ssl-profiles - see some context in https://github.com/sidorares/node-mysql2/issues/2581

dougwilson commented 5 months ago

Ya, there isn't a huge reason to update the built in certs here, as the new module splits them out. The separate module is great too bc then updating certs is separate from the version of the mysql module version as wlel.

https://github.com/mysqljs/aws-ssl-profiles?tab=readme-ov-file#mysqljsmysql is the usage example for how to uae the newest certs with thia module if it helps.