myst6re / hyne

Final Fantasy VIII Save Editor
https://www.ff8.fr
GNU General Public License v3.0
63 stars 7 forks source link

Remove foreach for C++11 ranged for #22

Closed sithlord48 closed 4 years ago

jeromearz commented 4 years ago

Can you provide docs about why this change is useful? (foreach macro deprecated, C++11 for loops more performant...)

sithlord48 commented 4 years ago

Its use is discouraged

Qt foreach macro docs

Note: Since Qt 5.7, the use of this macro is discouraged. It will be removed in a future version of Qt. Please use C++11 range-for, possibly with qAsConst(), as needed.

myst6re commented 4 years ago

Thanks!