Convert SIGNALS and SLOTS to Qt5 signals and slots

sithlord48 commented 2 years ago

Stop tracking the string locations in ts files (reduce unneeded updates on them)
Use Qt5 connections
- ListWidget::addAction needs updating due to how its creates actions
Use QPushButton::clicked in place of QPuchButton::released
Release both Qt5 and Qt6 assets
Fix up various Clazy / Clang issues

myst6re commented 2 years ago

* Release both Qt5 and Qt6 assets

No need to add this, I dropped Qt5 support

sithlord48 commented 2 years ago

* Release both Qt5 and Qt6 assets
No need to add this, I dropped Qt5 support

The CI Still has both ShouldQt5 be removed from the CI ?

sithlord48 commented 2 years ago

This is done to prevent possible detachment In vars

On Sat, Dec 18, 2021, 12:44 PM Jérôme Arzel @.***> wrote:

@.**** commented on this pull request.

In src/core/field/Opcode.cpp https://github.com/myst6re/makoureactor/pull/136#discussion_r771848451:

@@ -263,7 +263,7 @@ bool Opcode::searchVar(quint8 bank, quint16 address, Operation operation, int va } } else { // Every write vars

for (const FF7Var &var : vars) {

for (const FF7Var &var : qAsConst(vars)) {

Yeah, but there no need to set vars as const if var is not modified

— Reply to this email directly, view it on GitHub https://github.com/myst6re/makoureactor/pull/136#discussion_r771848451, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABY3BRFNDLKILERGXW3BEX3URTB6JANCNFSM5KJU6IYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

myst6re / makoureactor

Convert SIGNALS and SLOTS to Qt5 signals and slots #136

@.**** commented on this pull request.