mysterioustrousers / MTDates

A thread safe date calculation library with all the date functions you'll ever need.
BSD 2-Clause "Simplified" License
343 stars 68 forks source link

replacing deprecated week with weekOfYear #38

Closed jtrobman closed 10 years ago

jtrobman commented 10 years ago

This method was deprecated in iOS 7 and replaced with weekOfMonth and weekOfYear.

https://developer.apple.com/library/prerelease/ios/documentation/Cocoa/Reference/Foundation/Classes/NSDateComponents_Class/index.html#//apple_ref/occ/instm/NSDateComponents/week

vincilbishop commented 10 years ago

Is this going to be merged and the cocoapod updated?

atomkirk commented 10 years ago

Is weekOfYear backwards compatible?

jtrobman commented 10 years ago

Says in the documentation: Available in iOS 5.0 and later.

yas375 commented 10 years ago

+1 on this. weekOfYear is available since iOS 5. We have replaced usages of week in our app to weekOfYear a few month ago and haven't notice any problems. Would be nice to get MTDates updated soon :) thanks!

vincilbishop commented 10 years ago

Nice! Thanks for merging this...any chance we could get the cocoapod updated too with a new version?

atomkirk commented 10 years ago

0.14.0 published