search

mysterioustrousers / MTDates

A thread safe date calculation library with all the date functions you'll ever need.
BSD 2-Clause "Simplified" License
343 stars 68 forks source link

Fixed deprecation warnings for iOS 7 and above #45

Closed erudel closed 10 years ago

erudel commented 10 years ago

Also, fixed a bug in the Levenshtein algorithm that caused random crashes

atomkirk commented 10 years ago

This has all been taken care of and we're not going to use the Levenshtein approach to compare generated formatted strings by different OS versions. (we increased the min supported ios/osx versions, so if we still need a solution for getting unit tests to pass, we'll figure something else out besides using the Levenshtein distance approach)

atomkirk commented 10 years ago

Thanks for the work though

erudel commented 10 years ago

Ha, I just noticed that after creating the pull request. Oh well, thanks for fixing it :-)

yas375 commented 10 years ago

@atomkirk actually the first commit from this pull request (180cfc4 'Replace deprecated calendar identifiers and components') looks good to me (except a note regarding calendar identifier) and probably it makes sense to merge it as well. The commit with unit test fixes was probably an addition ;) Maybe it makes sense to ask @erudel to rebase the pull request on master and to make sure it doesn't use api available in iOS8 and above ;)

atomkirk commented 10 years ago

Agreed. If he's willing to do it, that'd be great. If a week goes by nothing's been done, hopefully I'll have time to take care of it myself.

erudel commented 10 years ago

Sure :) See https://github.com/mysterioustrousers/MTDates/pull/47