search

mysterioustrousers / MTDates

A thread safe date calculation library with all the date functions you'll ever need.
BSD 2-Clause "Simplified" License
343 stars 68 forks source link

Remove non-prefixed methods #56

Closed douglashill closed 9 years ago

douglashill commented 9 years ago

The non-prefixed methods were broken in commit 7f2fec8a4df2 in October 2013.

This pull request fixes this, so it successfully compiles with MTDATES_NO_PREFIX enabled. I fixed it because it was broken; I do not advocate using these methods.

The fact that nobody has complained in 18 months suggests it would be fine to remove the non-prefixed methods, but I leave that up to you.

yas375 commented 9 years ago

Indeed! :+1: Good reason to drop non-prefixed methods ;)

douglashill commented 9 years ago

If you like, I can add removing non-prefixed methods to this pull request.

yas375 commented 9 years ago

@douglashill I'm not maintainer of the lib. Probably @atomkirk is the right person to answer this ;)

atomkirk commented 9 years ago

yeah, I'm gonna remove the non-prefixed methods. I can't do it till this evening. If you submit a pull request with them all removed before then I'll merge it immediately

atomkirk commented 9 years ago

well crap, I didn't get the e-mail for your update, so I removed them myself. Sorry about that, thanks for helping. I've published it as 1.0.2.