search

mysterioustrousers / MTMigration

Manages blocks of code that only need to run once on version updates in iOS apps.
BSD 2-Clause "Simplified" License
914 stars 50 forks source link

Updated SenTests to XCTests. #24

Closed ajmccall closed 9 years ago

ajmccall commented 9 years ago

Updated SenTests to XCTests using xCode Convert To XCTests

Used XCTestExpectations, a block testing feature new to XCTest, to better check when or if blocks are being called in the tests.

Removed __block NSInteger val = 0; previously used to test blocks.

pwightman commented 9 years ago

Nice! Thank you. If I remember correctly, something changed on travis that's causing the tests not to run anymore, I think the .travis.yml needs to be tweaked. We'll see what happens

pwightman commented 9 years ago

Yeah, says it passes even though it didn't test anything. Blargh, let me see if I can fix that before merging this. https://travis-ci.org/mysterioustrousers/MTMigration/builds/58675306

ajmccall commented 9 years ago

That was quick. Just pushed a small change up. Moved [MTMigration reset]; into -(void) setup as this was happening before each test was being run.

pwightman commented 9 years ago

eh, the current tests are borked, merging this and then fixing travis.

pwightman commented 9 years ago

Boom: https://travis-ci.org/mysterioustrousers/MTMigration/builds/58700176 Also added the build status to the readme. Thanks a lot for this, really appreciate it!

ajmccall commented 9 years ago

No problem.

I have another PR which you may or may not like. Wanted to write a unit test for it, one thing lead to another and this was the result.