search

mysterioustrousers / MTMigration

Manages blocks of code that only need to run once on version updates in iOS apps.
BSD 2-Clause "Simplified" License
914 stars 50 forks source link

Uses build number (CFBundleVersion) instead #4

Closed kylefleming closed 9 years ago

kylefleming commented 11 years ago

I switched to using the build number since it's more in line with our internal versioning convention.

You might decide to integrate it into master for your own use. If you do so, you might also decide to change the NSUserDefaults keys to enable backwards compatibility.

Another con of CFBundleShortVersionString is that it's localizable, which might cause problems.

atomkirk commented 11 years ago

Well, we increment the build version on every single build, we don't keep it in sync with the app version, so that won't work for us, but you bring up a good point with localization. Any ideas @pwightman ?

pwightman commented 11 years ago

Yeah, I don't think we should change the existing method to use this, but I'm fine with creating another method. Something like migrateToBuildNumber, so both are options. @garthex if you'll refactor it to its own method, we'll merge it in. The localizable issue is important to note, however, so we should consider adding it as a warning to the README and to use migrateToBuildNumber if it becomes an issue.

vikfroberg commented 9 years ago

You might want to close this pull request, since we implemented the support for build number?